[tor-commits] [stem/master] Missing a requirement from test_get_latest_heartbeat

atagar at torproject.org atagar at torproject.org
Sun Jan 6 04:36:42 UTC 2013


commit 69a2d6d8aba1e538bdaf7f0ca8d2c66c57bb99de
Author: Damian Johnson <atagar at torproject.org>
Date:   Sat Jan 5 19:48:07 2013 -0800

    Missing a requirement from test_get_latest_heartbeat
    
    All controller tests (including test_get_latest_heartbeat) require an open
    control socket. Missing this requirement broke the RUN_NONE target.
---
 test/integ/control/base_controller.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/test/integ/control/base_controller.py b/test/integ/control/base_controller.py
index 8709469..319f7a8 100644
--- a/test/integ/control/base_controller.py
+++ b/test/integ/control/base_controller.py
@@ -188,6 +188,8 @@ class TestBaseController(unittest.TestCase):
     Basic check for get_latest_heartbeat().
     """
     
+    if test.runner.require_control(self): return
+    
     # makes a getinfo query, then checks that the heartbeat is close to now
     with test.runner.get_runner().get_tor_socket() as control_socket:
       controller = stem.control.BaseController(control_socket)





More information about the tor-commits mailing list