[tor-commits] [torbutton/master] Remove useless oncommand attributes.

mikeperry at torproject.org mikeperry at torproject.org
Thu Feb 14 06:09:26 UTC 2013


commit 302f69a9b70b362db531ecebd65f1f56db4eb2bd
Author: Mike Perry <mikeperry-git at fscked.org>
Date:   Thu Feb 7 17:56:19 2013 -0800

    Remove useless oncommand attributes.
    
    Most prefs only update things upon save.
---
 src/chrome/content/preferences.xul |   21 +++++++--------------
 1 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/chrome/content/preferences.xul b/src/chrome/content/preferences.xul
index e41dee8..10ddb69 100644
--- a/src/chrome/content/preferences.xul
+++ b/src/chrome/content/preferences.xul
@@ -101,11 +101,9 @@
                      </hbox>
                       <radiogroup align="center" orient="horizontal" id="torbutton_socksGroup">
                           <radio id="torbutton_socksv4"
-                                label="&torbutton.prefs.socks_vfour;" 
-                                oncommand="torbutton_prefs_set_field_attributes(document)"/>
+                                label="&torbutton.prefs.socks_vfour;"/>
                           <radio id="torbutton_socksv5" 
-                                label="&torbutton.prefs.socks_vfive;" 
-                                oncommand="torbutton_prefs_set_field_attributes(document)"/>
+                                label="&torbutton.prefs.socks_vfive;"/>
                       </radiogroup>
                     </row>
                     <row align="center">
@@ -139,8 +137,7 @@
        
         
         <checkbox id="torbutton_lockedMode"
-        label="&torbutton.prefs.locked_mode;"
-        oncommand="torbutton_prefs_set_field_attributes(document)"/>
+        label="&torbutton.prefs.locked_mode;"/>
 
         <hbox>
          <spacer flex="1"/>
@@ -163,17 +160,13 @@
     <tabpanel>
      <vbox>
        <checkbox id="torbutton_blockDisk" 
-              label="&torbutton.prefs.block_disk;" 
-              oncommand="torbutton_prefs_set_field_attributes(document)"/>
+              label="&torbutton.prefs.block_disk;"/>
        <checkbox id="torbutton_blockPlugins" 
-              label="&torbutton.prefs.block_plugins;" 
-              oncommand="torbutton_prefs_set_field_attributes(document)"/>
+              label="&torbutton.prefs.block_plugins;"/>
        <checkbox id="torbutton_restrictThirdParty" 
-              label="&torbutton.prefs.restrict_thirdparty;" 
-              oncommand="torbutton_prefs_set_field_attributes(document)"/>
+              label="&torbutton.prefs.restrict_thirdparty;"/>
        <checkbox id="torbutton_resistFingerprinting" 
-              label="&torbutton.prefs.resist_fingerprinting;" 
-              oncommand="torbutton_prefs_set_field_attributes(document)"/>
+              label="&torbutton.prefs.resist_fingerprinting;"/>
      </vbox>
     </tabpanel>
     <tabpanel>





More information about the tor-commits mailing list