[tor-commits] [tor/master] Fix memory leak in safe-cookie authentication code

[nickm at torproject.org]

commit 4b571d3ab3d4c8e13fe0bc73f15431294d19615a
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Dec 28 22:38:42 2012 -0500

    Fix memory leak in safe-cookie authentication code
    
    Coverity spotted this. Bug 7816. Fix on 0.2.3.13-alpha.
---
 changes/bug7816_023 |    3 +++
 src/or/control.c    |    2 ++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/changes/bug7816_023 b/changes/bug7816_023
new file mode 100644
index 0000000..cfa754a
--- /dev/null
+++ b/changes/bug7816_023
@@ -0,0 +1,3 @@
+  o Minor bugfixes (memory leak, controller):
+    - Fix a memory leak during safe-cookie controller authentication.
+      Spotted by Coverity. Fixes part of bug 7816; bugfix on 0.2.3.13-alpha.
diff --git a/src/or/control.c b/src/or/control.c
index 913d18a..fc7bae2 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -3099,6 +3099,8 @@ handle_control_authchallenge(control_connection_t *conn, uint32_t len,
                            "SERVERNONCE=%s\r\n",
                            server_hash_encoded,
                            server_nonce_encoded);
+
+  tor_free(client_nonce);
   return 0;
 }