[tor-commits] [tor/master] Fix warning when implicitly casting strlen(microdesc) to int

nickm at torproject.org nickm at torproject.org
Thu Sep 6 00:50:37 UTC 2012


commit 5d679caa32c71a8bc7d4ed4ab716349e603e642c
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Sep 5 20:49:25 2012 -0400

    Fix warning when implicitly casting strlen(microdesc) to int
    
    Harmless unless we somehow generate a microdesc of more than INT_MAX
    bytes.
---
 changes/ssize_t_warning |    4 ++++
 src/or/dirvote.c        |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/changes/ssize_t_warning b/changes/ssize_t_warning
new file mode 100644
index 0000000..01609cc
--- /dev/null
+++ b/changes/ssize_t_warning
@@ -0,0 +1,4 @@
+  o Minor build fixes:
+    - Fix a harmless (in this case) build warning for implicitly
+      converting a strlen() to an int. Bugfix on 0.2.4.1-alpha.
+
diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 8e85b2b..ea85636 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -3606,7 +3606,7 @@ dirvote_format_microdesc_vote_line(char *out_buf, size_t out_buf_len,
                                    int consensus_method_low,
                                    int consensus_method_high)
 {
-  int ret = -1;
+  ssize_t ret = -1;
   char d64[BASE64_DIGEST256_LEN+1];
   char *microdesc_consensus_methods =
     make_consensus_method_list(consensus_method_low,



More information about the tor-commits mailing list