[tor-commits] [ooni-probe/master] Fix bug that lead to httpt based reports to not have the url attribute set properly

art at torproject.org art at torproject.org
Mon Nov 19 18:03:50 UTC 2012


commit 51902f84f2849e17164bd100141d0f5ef5aa151a
Author: Arturo Filastò <art at fuffa.org>
Date:   Mon Nov 19 18:05:28 2012 +0100

    Fix bug that lead to httpt based reports to not have the url attribute set properly
    * It has to do with the fact that the request dict was being passed to the
      report as a reference and not being reinstanced for every test
---
 ooni/templates/httpt.py |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/ooni/templates/httpt.py b/ooni/templates/httpt.py
index c2db6f5..9bce30f 100644
--- a/ooni/templates/httpt.py
+++ b/ooni/templates/httpt.py
@@ -146,7 +146,9 @@ class HTTPTest(NetTestCase):
             self.randomize_useragent()
 
         log.debug("Writing to report the request")
-        self.report['request'] = self.request
+        # Here we need to create a copy of the request object for reporting
+        # purposes
+        self.report['request'] = dict(self.request)
 
         # If we have a request body payload, set the request body to such
         # content





More information about the tor-commits mailing list