[tor-commits] [tor/maint-0.2.3] Turn a memwipe in tor_process_handle_destroy() back to memset

nickm at torproject.org nickm at torproject.org
Fri Nov 9 01:00:42 UTC 2012


commit e567b4482a1473f586a8549d9311d989c2335172
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Nov 8 19:59:54 2012 -0500

    Turn a memwipe in tor_process_handle_destroy() back to memset
    
    It broke linking on tor-resolve.c, and it's not actually sanitizing
    anything sensitive.  Fix for bug 7420; bug not on ony released Tor.
---
 src/common/util.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/common/util.c b/src/common/util.c
index 005c2b5..6fb597a 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3808,7 +3808,7 @@ tor_process_handle_destroy(process_handle_t *process_handle,
     fclose(process_handle->stderr_handle);
 #endif
 
-  memwipe(process_handle, 0x0f, sizeof(process_handle_t));
+  memset(process_handle, 0x0f, sizeof(process_handle_t));
   tor_free(process_handle);
 }
 



More information about the tor-commits mailing list