[tor-commits] [tor/master] Fix a couple of "unused assigned value" warnings in parse_config tests

nickm at torproject.org nickm at torproject.org
Fri Mar 30 14:38:35 UTC 2012


commit 88caa552cc3742189124c297e7cf65ac5e5ef332
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Mar 30 10:26:34 2012 -0400

    Fix a couple of "unused assigned value" warnings in parse_config tests
    
    Coverity doesn't like the fact that we were storing the value of
    parse_config_line_from_str() but not checking it in a couple of
    cases.
    
    Fixes CID 505 and 506.
---
 src/test/test_util.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 0f9d1a7..88f00e0 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -388,6 +388,8 @@ test_util_config_line_comment_character(void)
   test_streq(v, "some value");
   tor_free(k); tor_free(v);
 
+  test_streq(str, "k3 /home/user/myTorNetwork#2\n");
+
 #if 0
   str = parse_config_line_from_str(str, &k, &v);
   test_streq(k, "k3");
@@ -499,6 +501,7 @@ test_util_config_line_escaped_content(void)
   test_streq(k, "Mix");
   test_streq(v, "This is a \"star\":\t'*'\nAnd second line");
   tor_free(k); tor_free(v);
+  test_streq(str, "");
 
   str = buf2;
 





More information about the tor-commits mailing list