[tor-commits] [tor/master] Remove unreliable assertion

nickm at torproject.org nickm at torproject.org
Fri Mar 9 16:30:59 UTC 2012


commit a3679d30c050c96b43c17e8a8be4dc56490afe52
Author: Esteban Manchado Velázquez <emanchado at demiurgo.org>
Date:   Sat Feb 18 19:29:48 2012 +0100

    Remove unreliable assertion
    
    * This assertion fails when executing the whole suite, but not when executing
      this test by itself
    * Ideally I'd prefer starting with a guaranteed empty directory, but it's not
      very important in this case as non-existence of other paths is being checked
      explicitly
---
 src/test/test_util.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 3efe617..3860f15 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -1644,7 +1644,6 @@ test_util_listdir(void *ptr)
   dir_contents = tor_listdir(dirname);
   test_assert(dir_contents);
   /* make sure that each filename is listed. */
-  test_eq(4, smartlist_len(dir_contents));
   test_assert(smartlist_string_isin_case(dir_contents, "hopscotch"));
   test_assert(smartlist_string_isin_case(dir_contents, "mumblety-peg"));
   test_assert(smartlist_string_isin_case(dir_contents, ".hidden-file"));





More information about the tor-commits mailing list