[tor-commits] [tor/master] Don't leak the env_vars_sorted smartlist in process_environment_make

nickm at torproject.org nickm at torproject.org
Thu Mar 1 00:50:56 UTC 2012


commit 77a7a980d0ab0bbfd4d99a062dbb0b5eadaa32ce
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Feb 28 10:25:39 2012 -0800

    Don't leak the env_vars_sorted smartlist in process_environment_make
    
    Found by Coverity.
    
    No changes/ file, because this bug has not been in a release yet.
---
 src/common/util.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/common/util.c b/src/common/util.c
index 5fd8c2d..ecf49a6 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3823,6 +3823,8 @@ process_environment_make(struct smartlist_t *env_vars)
     tor_assert(cp == env->windows_environment_block + total_env_length - 1);
   }
 
+  smartlist_free(env_vars_sorted);
+
   return env;
 }
 



More information about the tor-commits mailing list