[tor-commits] [tor/master] test_assert is always in affect: no need for extra gotos

nickm at torproject.org nickm at torproject.org
Tue Jul 31 21:10:17 UTC 2012


commit 3763959ef0d0510628ec4f54cb3df09f963bc4bd
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Jul 31 14:35:19 2012 -0400

    test_assert is always in affect: no need for extra gotos
---
 src/test/test_introduce.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/test/test_introduce.c b/src/test/test_introduce.c
index 72ab555..4fbfd18 100644
--- a/src/test/test_introduce.c
+++ b/src/test/test_introduce.c
@@ -291,10 +291,8 @@ do_parse_test(uint8_t *plaintext, size_t plaintext_len, int phase)
   /* Get a key */
   k = crypto_pk_new();
   test_assert(k);
-  if (!k) goto done;
   r = crypto_pk_read_private_key_from_string(k, AUTHORITY_SIGNKEY_1, -1);
   test_assert(!r);
-  if (r) goto done;
 
   /* Get digest for future comparison */
   r = crypto_pk_get_digest(k, digest);
@@ -306,7 +304,6 @@ do_parse_test(uint8_t *plaintext, size_t plaintext_len, int phase)
       k, (void **)(&cell));
   test_assert(r > 0);
   test_assert(cell);
-  if (!(cell && r > 0)) goto done;
   cell_len = r;
 
   /* Do early parsing */





More information about the tor-commits mailing list