[tor-commits] [flashproxy/master] Use an iframe attribute called frameborder not frameBorder.

dcf at torproject.org dcf at torproject.org
Tue Jul 10 17:00:44 UTC 2012


commit 154bcc1c9dc34c657448498a708a8097c870f856
Author: David Fifield <david at bamsoftware.com>
Date:   Tue Jul 10 09:47:03 2012 -0700

    Use an iframe attribute called frameborder not frameBorder.
    
    I got a notice from Joseph Long that our iframe code didn't validate as
    XHTML because of the frameBorder element. (XHTML 1.0 doesn't even have
    the iframe element, but XHTML 1.0 Transitional and XHTML 1.0 Frameset
    do.) It turns out that the attribute name must be all lower-case:
    
    http://www.w3.org/TR/xhtml1/#h-4.2
    http://www.w3.org/TR/1999/xhtml-modularization-19990406/DTD/doc/xhtml1-f.elt.html#iframe
    
    I think I originally had the capital B because it's required by some
    versions of IE:
    
    http://stackoverflow.com/questions/65034/remove-border-from-iframe/65052#65052
    
    Apparently setting the CSS "border" property to 0 also has problems with
    some versions of IE:
    
    http://stackoverflow.com/questions/65034/remove-border-from-iframe/8437926#8437926
---
 README |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/README b/README
index e096a3f..b8b2f5c 100644
--- a/README
+++ b/README
@@ -126,7 +126,7 @@ Add this line to torrc to make the relay use the external proxy:
 
 Paste in this HTML where you want the badge to appear:
 
-<iframe src="//crypto.stanford.edu/flashproxy/embed.html" width="80" height="15" frameBorder="0" scrolling="no"></iframe>
+<iframe src="//crypto.stanford.edu/flashproxy/embed.html" width="80" height="15" frameborder="0" scrolling="no"></iframe>
 
 
 == For developers



More information about the tor-commits mailing list