[tor-commits] [tor/master] Log which votes we still need to fetch

[nickm at torproject.org]

commit 6b9298ef72997c1cd0ed2e9c47abeb6c06f64f9f
Author: Sebastian Hahn <sebastian at torproject.org>
Date:   Tue Jan 10 16:12:22 2012 +0100

    Log which votes we still need to fetch
    
    This might help us see which authorities are problematic in getting
    their vote published the first time.
---
 changes/dirauth_log |    3 +++
 src/or/dirvote.c    |    9 +++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/changes/dirauth_log b/changes/dirauth_log
new file mode 100644
index 0000000..df82314
--- /dev/null
+++ b/changes/dirauth_log
@@ -0,0 +1,3 @@
+  o Minor features:
+    - Log which authority we're missing votes from when we go to fetch them
+      from the other auths.
diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 2843336..3bb165a 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -2801,8 +2801,13 @@ dirvote_fetch_missing_votes(void)
     smartlist_free(missing_fps);
     return;
   }
-  log_notice(LOG_NOTICE, "We're missing votes from %d authorities. Asking "
-             "every other authority for a copy.", smartlist_len(missing_fps));
+  {
+    char *tmp = smartlist_join_strings(missing_fps, " ", 0, NULL);
+    log_notice(LOG_NOTICE, "We're missing votes from %d authorities (%s). "
+               "Asking every other authority for a copy.",
+               smartlist_len(missing_fps), tmp);
+    tor_free(tmp);
+  }
   resource = smartlist_join_strings(missing_fps, "+", 0, NULL);
   directory_get_from_all_authorities(DIR_PURPOSE_FETCH_STATUS_VOTE,
                                      0, resource);