[tor-commits] [tor/master] Downgrade "missing a certificate" from notice to info

[nickm at torproject.org]

commit c8b855082bdb4ea5f9006e6ce5ce673509643a5c
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Feb 10 12:01:56 2012 -0500

    Downgrade "missing a certificate" from notice to info
    
    It was apparently getting mistaken for a problem, even though it was
    at notice.
    
    Fixes 5067; fix on 0.2.0.10-alpha.
---
 changes/bug5067     |    5 +++++
 src/or/routerlist.c |    6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/changes/bug5067 b/changes/bug5067
new file mode 100644
index 0000000..d94b921
--- /dev/null
+++ b/changes/bug5067
@@ -0,0 +1,5 @@
+  o Minor bugfixes (usability):
+    - Downgrade the "We're missing a certificate" message from notice
+      to info: people kept mistaking it for a real problem, whereas it
+      is only a problem when we are failing to bootstrap. Fixes bug
+      5067; bugfix on 0.2.10-alpha.
diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index f8df089..1edf651 100644
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -504,9 +504,9 @@ authority_certs_fetch_missing(networkstatus_t *status, time_t now)
         if (download_status_is_ready(&cl->dl_status, now,
                                      MAX_CERT_DL_FAILURES) &&
             !digestmap_get(pending, voter->identity_digest)) {
-          log_notice(LD_DIR, "We're missing a certificate from authority "
-                     "with signing key %s: launching request.",
-                     hex_str(sig->signing_key_digest, DIGEST_LEN));
+          log_info(LD_DIR, "We're missing a certificate from authority "
+                   "with signing key %s: launching request.",
+                   hex_str(sig->signing_key_digest, DIGEST_LEN));
           smartlist_add(missing_digests, sig->identity_digest);
         }
       } SMARTLIST_FOREACH_END(sig);