[tor-commits] [stem/master] Reporting testing as having failed if tor can't start

atagar at torproject.org atagar at torproject.org
Fri Dec 21 16:07:25 UTC 2012


commit bf2f7f2a461b535ddd21728e29dc2091ef35a74d
Author: Damian Johnson <atagar at torproject.org>
Date:   Fri Dec 21 08:06:15 2012 -0800

    Reporting testing as having failed if tor can't start
    
    As pointed out by Simon on...
    https://lists.torproject.org/pipermail/tor-dev/2012-December/004296.html
    
    ... we presently say that testing has passed if tor fails to start. This is
    wrong.
---
 run_tests.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/run_tests.py b/run_tests.py
index 129c479..fdc2696 100755
--- a/run_tests.py
+++ b/run_tests.py
@@ -438,7 +438,7 @@ if __name__ == '__main__':
         test.output.print_line("  aborted starting tor: keyboard interrupt\n", *ERROR_ATTR)
         break
       except OSError:
-        pass
+        testing_failed = True
       finally:
         integ_runner.stop()
     



More information about the tor-commits mailing list