[tor-commits] [tor/master] Speak not the name of INT_MIN; it can upset older compilers

nickm at torproject.org nickm at torproject.org
Fri Aug 3 18:01:26 UTC 2012


commit d373922217dc8c2c2f1bcb243f2b8b08379d0582
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Aug 3 13:54:12 2012 -0400

    Speak not the name of INT_MIN; it can upset older compilers
    
    And more to the point, some GCCs will warn that you can't say it
    before C90.
    
    Bug not in any released version of Tor.
---
 src/test/test_util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 5c119d3..64976f3 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -1620,7 +1620,7 @@ test_util_sscanf(void)
 #if SIZEOF_INT == 4
   r = tor_sscanf("-2147483648. 2147483647.", "%d. %d.", &int1, &int2);
   test_eq(r,2);
-  test_eq(int1, -2147483648);
+  test_eq(int1, -2147483647-1);
   test_eq(int2, 2147483647);
 
   r = tor_sscanf("-2147483679.", "%d.", &int1);
@@ -1632,7 +1632,7 @@ test_util_sscanf(void)
   r = tor_sscanf("-9223372036854775808. 9223372036854775807.",
                  "%d. %d.", &int1, &int2);
   test_eq(r,2);
-  test_eq(int1, -9223372036854775808);
+  test_eq(int1, -9223372036854775807-1);
   test_eq(int2, 9223372036854775807);
 
   r = tor_sscanf("-9223372036854775809.", "%d.", &int1);



More information about the tor-commits mailing list