[tor-commits] [tor/master] Say that bug4438 was a fix on

nickm at torproject.org nickm at torproject.org
Tue Apr 24 15:21:28 UTC 2012

commit 54520e49cd2a10778e7c58d797f22a768da6557a
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Mar 28 10:41:12 2012 -0400

    Say that bug4438 was a fix on
    Specifically, it was a fix on 33e2053ebca5d, where we introduced the
    WRA_* and ROUTER_* codes for dirserv_add_descriptor.  Previously, we
    had checked for a _negative_ return from dirserv_add_descriptor, which
    meant "rejected".  An insufficiently new descriptor would give a
    0-valued return.  But when we switched from numbers to enums, we got
    this check wrong and had init_keys() give an error whenever the
    descriptor wasn't accepted.
 changes/bug4438 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/changes/bug4438 b/changes/bug4438
index f6d0c49..94690e1 100644
--- a/changes/bug4438
+++ b/changes/bug4438
@@ -2,5 +2,5 @@
     - Fix a dirauth-only exit on sighup that could happen during some
       configuration state transitions. We now don't treat it as a fatal
       error when the new descriptor we just generated in init_keys
-      isn't accepted. Fixes bug 4438; bugfix on FIXME.
+      isn't accepted. Fixes bug 4438; bugfix on

More information about the tor-commits mailing list