[tor-commits] [torbel/master] Add a TODO note for router.unreachable

sebastian at torproject.org sebastian at torproject.org
Sat Nov 19 00:42:12 UTC 2011


commit 12b290b25f16bd72275e72cddaa013d2ebfc8cc0
Author: Sebastian Hahn <sebastian at torproject.org>
Date:   Sat Nov 19 01:40:37 2011 +0100

    Add a TODO note for router.unreachable
    
    We have to handle the case where circuit creation always succeeds, but
    streams still fail to get to us without a real error message
---
 scheduler.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/scheduler.py b/scheduler.py
index e246732..6127f6c 100644
--- a/scheduler.py
+++ b/scheduler.py
@@ -155,6 +155,8 @@ class TestScheduler:
                 return
 
         # If we BUILT a circuit to this router, it is not unreachable.
+        # TODO: But it could still be that all streams through it fail,
+        # with inconclusive error messages. We have to handle that!
         router.unreachable = False
         # If we succeeded in building this router on retry,
         # reset its failure count to give it a clean slate.



More information about the tor-commits mailing list