[tor-commits] [tor/master] Fix up some comment issues spotted by rransom

nickm at torproject.org nickm at torproject.org
Mon May 16 00:23:00 UTC 2011


commit 287f6cb128c890e31faa951be6d42cd6801f4e59
Author: Nick Mathewson <nickm at torproject.org>
Date:   Sun May 15 13:03:15 2011 -0400

    Fix up some comment issues spotted by rransom
---
 src/common/compat.c |    7 ++++++-
 src/common/util.c   |    6 +++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/common/compat.c b/src/common/compat.c
index 3c5e938..fc066da 100644
--- a/src/common/compat.c
+++ b/src/common/compat.c
@@ -1481,7 +1481,12 @@ get_parent_directory(char *fname)
     fname += 2;
   }
 #endif
-  /* Now we want to remove the final character that */
+  /* Now we want to remove all path-separators at the end of the string,
+   * and to remove the end of the string starting with the path separator
+   * before the last non-path-separator.  In perl, this would be
+   *   s#[/]*$##; s#/[^/]*$##;
+   * on a unixy platform.
+   */
   cp = fname + strlen(fname);
   at_end = 1;
   while (--cp > fname) {
diff --git a/src/common/util.c b/src/common/util.c
index d84ed9c..0e739f2 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -1664,10 +1664,10 @@ file_status(const char *fname)
     return FN_ERROR;
 }
 
-/** Check whether dirname exists and is private.  If yes return 0.  If
- * it does not exist, and check&CPD_CREATE is set, try to create it
+/** Check whether <b>dirname</b> exists and is private.  If yes return 0.  If
+ * it does not exist, and <b>check</b>&CPD_CREATE is set, try to create it
  * and return 0 on success. If it does not exist, and
- * check&CPD_CHECK, and we think we can create it, return 0.  Else
+ * <b>check</b>&CPD_CHECK, and we think we can create it, return 0.  Else
  * return -1.  If CPD_GROUP_OK is set, then it's okay if the directory
  * is group-readable, but in all cases we create the directory mode 0700.
  * If CPD_CHECK_MODE_ONLY is set, then we don't alter the directory permissions





More information about the tor-commits mailing list