[tor-commits] [tor/master] Don't clear out transient addressmap entries on HUP

[nickm at torproject.org]

commit 09da83e1e8c1f1050fd65af86736abc1f4e5b530
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri May 13 16:20:01 2011 -0400

    Don't clear out transient addressmap entries on HUP
    
    If you really want to purge the client DNS cache, the TrackHostExits
    mappings, and the virtual address mappings, you should be using NEWNYM
    instead.
    
    Fixes bug 1345; bugfix on Tor 0.1.0.1-rc.
    
    Note that this needs more work: now that we aren't nuking the
    transient addressmap entries on HUP, we need to make sure that
    configuration changes to VirtualAddressMap and TrackHostExits actually
    have a reasonable effect.
---
 changes/bug1345 |    4 ++++
 src/or/main.c   |    1 -
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/changes/bug1345 b/changes/bug1345
new file mode 100644
index 0000000..6945b5f
--- /dev/null
+++ b/changes/bug1345
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - On SIGHUP, do not clear out all TrackExitHost mappings, client DNS
+      cache entries, and virtual address mappings: that's what NEWNYM is
+      for.  Bugfix on Tor 0.1.0.1-rc; fixes bug 1345.
diff --git a/src/or/main.c b/src/or/main.c
index 15682d5..d700f0e 100644
--- a/src/or/main.c
+++ b/src/or/main.c
@@ -1417,7 +1417,6 @@ do_hup(void)
 
   router_reset_warnings();
   routerlist_reset_warnings();
-  addressmap_clear_transient();
   /* first, reload config variables, in case they've changed */
   if (options->ReloadTorrcOnSIGHUP) {
     /* no need to provide argc/v, they've been cached in init_from_config */