[or-cvs] [tor/release-0.2.2] Add missing check for hostname answer_len in dnsserv size

arma at torproject.org arma at torproject.org
Sat Jan 15 22:31:52 UTC 2011


commit 31b562e10abe51cf9d520e0a3ad2ffc3277d52a4
Author: Nick Mathewson <nickm at torproject.org>
Date:   Sat Jan 15 13:09:12 2011 -0500

    Add missing check for hostname answer_len in dnsserv size
    
    This is checked elsewhere too, but let's be RFC-conformant.
---
 src/or/dnsserv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/or/dnsserv.c b/src/or/dnsserv.c
index 57c4493..f8b5c3c 100644
--- a/src/or/dnsserv.c
+++ b/src/or/dnsserv.c
@@ -271,6 +271,7 @@ dnsserv_resolved(edge_connection_t *conn,
                                      name,
                                      1, (char*)answer, ttl);
   } else if (answer_type == RESOLVED_TYPE_HOSTNAME &&
+             answer_len < 256 &&
              conn->socks_request->command == SOCKS_COMMAND_RESOLVE_PTR) {
     char *ans = tor_strndup(answer, answer_len);
     evdns_server_request_add_ptr_reply(req, NULL,





More information about the tor-commits mailing list