[or-cvs] [tor/release-0.2.1] Fix two more SIZE_T_CEILING issues

arma at torproject.org arma at torproject.org
Fri Feb 11 06:04:05 UTC 2011


commit 971e83ef9c284ff82fdeedb7851fed5b3386dd1a
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Jan 19 13:22:50 2011 -0500

    Fix two more SIZE_T_CEILING issues
    
    This patch imposes (very long) limits on the length of a line in a
    directory document, and on the length of a certificate.  I don't
    think it should actually be possible to overrun these remotely,
    since we already impose a maximum size on any directory object we're
    downloading, but a little defensive programming never hurt anybody.
    
    Roger emailed me that doorss reported these on IRC, but nobody seems
    to have put them on the bugtracker.
---
 changes/routerparse_maxima |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/changes/routerparse_maxima b/changes/routerparse_maxima
new file mode 100644
index 0000000..340f2c3
--- /dev/null
+++ b/changes/routerparse_maxima
@@ -0,0 +1,4 @@
+  o Minor bugfixes
+    - Check for and reject overly long directory certificates and
+      directory tokens before they have a chance to hit any
+      assertions. Bugfix on 0.2.1.28. Found by doorss.





More information about the tor-commits mailing list