[tor-commits] [doctor/master] Don't warn if authorities don't recommend any versions.

[karsten at torproject.org]

commit b018b58523a6041b3bbd2dee9d7d2d876bb9c491
Author: Karsten Loesing <karsten.loesing at gmx.net>
Date:   Tue Dec 13 12:05:47 2011 +0100

    Don't warn if authorities don't recommend any versions.
    
    Spotted by Robert.
---
 src/org/torproject/doctor/Checker.java |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/org/torproject/doctor/Checker.java b/src/org/torproject/doctor/Checker.java
index ee4e29e..795a730 100755
--- a/src/org/torproject/doctor/Checker.java
+++ b/src/org/torproject/doctor/Checker.java
@@ -208,7 +208,7 @@ public class Checker {
     SortedSet<String> unrecommendedClientVersions = new TreeSet<String>(),
         unrecommendedServerVersions = new TreeSet<String>();
     for (RelayNetworkStatusVote vote : this.downloadedVotes) {
-      if (vote.getRecommendedClientVersions() != null &&
+      if (!vote.getRecommendedClientVersions().isEmpty() &&
           !downloadedConsensus.getRecommendedClientVersions().equals(
           vote.getRecommendedClientVersions())) {
         StringBuilder message = new StringBuilder();
@@ -218,7 +218,7 @@ public class Checker {
         }
         unrecommendedClientVersions.add(message.toString());
       }
-      if (vote.getRecommendedServerVersions() != null &&
+      if (!vote.getRecommendedServerVersions().isEmpty() &&
           !downloadedConsensus.getRecommendedServerVersions().equals(
           vote.getRecommendedServerVersions())) {
         StringBuilder message = new StringBuilder();