[tor-commits] [tor/master] Use smartlist_asprintf_add() to improve readability.

nickm at torproject.org nickm at torproject.org
Wed Aug 10 19:06:43 UTC 2011


commit 86f68ed6953620e14c7f9894e01ab2eafea250e7
Author: Kamran Riaz Khan <krkhan at inspirated.com>
Date:   Tue Aug 9 15:18:57 2011 +0500

    Use smartlist_asprintf_add() to improve readability.
---
 src/or/control.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/or/control.c b/src/or/control.c
index 3943aff..706d871 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -4015,13 +4015,11 @@ control_event_conf_changed(smartlist_t *elements)
   for (i = 0; i < smartlist_len(elements); i += 2) {
     char *k = smartlist_get(elements, i);
     char *v = smartlist_get(elements, i+1);
-    char *tmp;
     if (v == NULL) {
-      tor_asprintf(&tmp, "650-%s", k);
+      smartlist_asprintf_add(lines, "650-%s", k);
     } else {
-      tor_asprintf(&tmp, "650-%s=%s", k, v);
+      smartlist_asprintf_add(lines, "650-%s=%s", k, v);
     }
-    smartlist_add(lines, tmp);
   }
   result = smartlist_join_strings(lines, "\r\n", 0, NULL);
   send_control_event(EVENT_CONF_CHANGED, 0,





More information about the tor-commits mailing list