[or-cvs] [metrics-db/master] Fix directly connecting users graphs a bit more.

karsten at torproject.org karsten at torproject.org
Thu Sep 23 07:01:35 UTC 2010


Author: Karsten Loesing <karsten.loesing at gmx.net>
Date: Thu, 23 Sep 2010 08:51:45 +0200
Subject: Fix directly connecting users graphs a bit more.
Commit: 7150af1e45ab30caf0a9d64317656f9a9933c66a

Our user number estimates are less precise the fewer requests a directory
mirror sees. Take out all data points when trusted saw less than 1 % of
all requests.

This is only a quick fix of an approach that is already broken. We should
combine findings of more than 1 directory mirror and investigate the other
approaches to estimate user numbers.
---
 R/dirreq-stats.R |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/R/dirreq-stats.R b/R/dirreq-stats.R
index eedaf03..34e2a43 100644
--- a/R/dirreq-stats.R
+++ b/R/dirreq-stats.R
@@ -185,9 +185,9 @@ if (file.exists("stats/dirreq-stats")) {
     "8522EB98C91496E80EC238E732594D1509158E77",]
   trustedSub[!is.na(trustedSub$share) & trustedSub$share < 0.01,
     3:length(trustedSub)] <- NA
-  # Take out values in June 2010 when we had problems with dirreq-shares
-  trustedSub[!is.na(trustedSub$share) & trustedSub$date > "2010-05-26"
-             & trustedSub$date < "2010-06-24", 3:length(trustedSub)] <- NA
+  # Take out values when trusted saw less than 1 % of all requests
+  trustedSub[!is.na(trustedSub$share) & trustedSub$share < 1,
+             3:length(trustedSub)] <- NA
   trusted <- data.frame(date = trustedSub$date,
     floor(trustedSub[3:(length(trustedSub) - 1)] / trustedSub$share * 10))
 
-- 
1.7.1



More information about the tor-commits mailing list