[or-cvs] [tor/master 2/8] Note icky constructs mentioned in bug #1903

[nickm at torproject.org]

Author: Steven Murdoch <Steven.Murdoch at cl.cam.ac.uk>
Date: Mon, 4 Oct 2010 14:19:17 +0100
Subject: Note icky constructs mentioned in bug #1903
Commit: 708ba8899f21a03564d96eccc202c3c7a37994bb

- To be dealt with as part of bug #2029
---
 src/common/util.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/common/util.c b/src/common/util.c
index 6c7794d..afd9d2e 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3061,7 +3061,8 @@ tor_spawn_background(const char *const filename, int *stdout_read,
     child_state = CHILD_STATE_CLOSEFD;
 
     /* Close all other fds, including the read end of the pipe */
-    /* TODO: use closefrom if available */
+    /* XXX: use closefrom if available, or better still set FD_CLOEXEC
+       on all of Tor's open files */
     for (fd = STDERR_FILENO + 1; fd < max_fd; fd++)
       close(fd);
 
@@ -3077,7 +3078,7 @@ tor_spawn_background(const char *const filename, int *stdout_read,
     child_state = CHILD_STATE_FAILEXEC;
 
   error:
-    /* TODO: are we leaking fds from the pipe? */
+    /* XXX: are we leaking fds from the pipe? */
 
     format_helper_exit_status(child_state, errno, hex_errno);
 
-- 
1.7.1