[or-cvs] [tor/master] use ssp-buffer-size=1 to avoid Werror failures

arma at torproject.org arma at torproject.org
Fri May 7 20:06:59 UTC 2010

Author: Andy Isaacson <adi at hexapodia.org>
Date: Fri, 7 May 2010 12:22:44 -0700
Subject: use ssp-buffer-size=1 to avoid Werror failures
Commit: 6751899fe1c85ad7fdddc9fea74387098ecab015

Build on Ubuntu 10.04 64-bit was failing:

util.c: In function ‘parse_http_time’:
util.c:1370: error: not protecting function: no buffer at least 8 bytes long

We don't want to lose -Werror, and we don't care too much about the
added overhead of protecting even small buffers, so let's simply turn on
SSP for all buffers.

Thanks to Jacob Appelbaum for the pointer and SwissTorExit for the
original report.

Signed-off-by: Andy Isaacson <adi at hexapodia.org>
 configure.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.in b/configure.in
index 07b3ff4..46c3c19 100644
--- a/configure.in
+++ b/configure.in
@@ -885,7 +885,7 @@ if test x$enable_gcc_warnings = xyes || test x$enable_gcc_warnings_advisory = xy
     # These warnings break gcc 4.0.2 and work on gcc 4.2
     # XXXX020 Use -fstack-protector.
     # XXXX020 See if any of these work with earlier versions.
-    CFLAGS="$CFLAGS -Waddress -Wmissing-noreturn -Wnormalized=id -Woverride-init -Wstrict-overflow=1"
+    CFLAGS="$CFLAGS -Waddress -Wmissing-noreturn -Wnormalized=id -Woverride-init -Wstrict-overflow=1 --param ssp-buffer-size=1"
     # We used to use -Wstrict-overflow=5, but that breaks us heavily under 4.3.

More information about the tor-commits mailing list