[or-cvs] [tor/master] Fix dead code found by Coverity (CID 419).

Nick Mathewson nickm at seul.org
Tue Oct 27 02:40:45 UTC 2009


Author: Nick Mathewson <nickm at torproject.org>
Date: Mon, 26 Oct 2009 22:15:13 -0400
Subject: Fix dead code found by Coverity (CID 419).
Commit: caa141617f324138b329051520dcdf0d9289d618

This was left over from an early draft of the microdescriptor code; it
began to populate the signatures array of a networkstatus vote, even
though there's no actual need to do that for a vote.
---
 src/or/dirserv.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/or/dirserv.c b/src/or/dirserv.c
index 6ce6a46..d9a5dec 100644
--- a/src/or/dirserv.c
+++ b/src/or/dirserv.c
@@ -2609,11 +2609,6 @@ dirserv_generate_networkstatus_vote_obj(crypto_pk_env_t *private_key,
   voter->nickname = tor_strdup(options->Nickname);
   memcpy(voter->identity_digest, identity_digest, DIGEST_LEN);
   voter->sigs = smartlist_create();
-  {
-    document_signature_t *sig = tor_malloc_zero(sizeof(document_signature_t));
-    memcpy(sig->identity_digest, identity_digest, DIGEST_LEN);
-    memcpy(sig->signing_key_digest, signing_key_digest, DIGEST_LEN);
-  }
   voter->address = hostname;
   voter->addr = addr;
   voter->dir_port = options->DirPort;
-- 
1.5.6.5




More information about the tor-commits mailing list