[or-cvs] [tor/master] Clarification to suppress Coverity CID 405.

Nick Mathewson nickm at seul.org
Tue Oct 27 02:40:43 UTC 2009


Author: Nick Mathewson <nickm at torproject.org>
Date: Mon, 26 Oct 2009 21:42:15 -0400
Subject: Clarification to suppress Coverity CID 405.
Commit: a457cd91fafdce6e7d63ef2089233768498335f2

Every or conn has an outbuf, but coverity has no way of knowing that.
Add an assert to ease its conscience.
---
 src/or/main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/or/main.c b/src/or/main.c
index 9605b2b..537abcc 100644
--- a/src/or/main.c
+++ b/src/or/main.c
@@ -731,6 +731,7 @@ run_connection_housekeeping(int i, time_t now)
     return; /* we're all done here, the rest is just for OR conns */
 
   or_conn = TO_OR_CONN(conn);
+  tor_assert(conn->outbuf);
 
   if (or_conn->is_bad_for_new_circs && !or_conn->n_circuits) {
     /* It's bad for new circuits, and has no unmarked circuits on it:
-- 
1.5.6.5




More information about the tor-commits mailing list