[or-cvs] r17982: {tor} Note a problem in the interface tor_addr_to_sockaddr. (tor/trunk/src/common)

[nickm at seul.org]

Author: nickm
Date: 2009-01-06 15:50:51 -0500 (Tue, 06 Jan 2009)
New Revision: 17982

Modified:
   tor/trunk/src/common/address.c
Log:
Note a problem in the interface tor_addr_to_sockaddr.

Modified: tor/trunk/src/common/address.c
===================================================================
--- tor/trunk/src/common/address.c	2009-01-06 20:42:31 UTC (rev 17981)
+++ tor/trunk/src/common/address.c	2009-01-06 20:50:51 UTC (rev 17982)
@@ -53,6 +53,8 @@
  * socklen object in *<b>sa_out</b> of object size <b>len</b>.  If not enough
  * room is free, or on error, return -1.  Else return the length of the
  * sockaddr. */
+/* XXXX021 This returns socklen_t.  socklen_t is sometimes unsigned.  This
+ *   function claims to return -1 sometimes.  Problematic! */
 socklen_t
 tor_addr_to_sockaddr(const tor_addr_t *a,
                      uint16_t port,