[or-cvs] r16758: {tor} An asterisk makes a difference sometimes. Fixes bug 809. (in tor/trunk: . src/common)

[nickm at seul.org]

Author: nickm
Date: 2008-09-04 16:42:02 -0400 (Thu, 04 Sep 2008)
New Revision: 16758

Modified:
   tor/trunk/ChangeLog
   tor/trunk/src/common/address.c
Log:
An asterisk makes a difference sometimes.  Fixes bug 809.

Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2008-09-04 16:29:21 UTC (rev 16757)
+++ tor/trunk/ChangeLog	2008-09-04 20:42:02 UTC (rev 16758)
@@ -2,6 +2,9 @@
   o Minor bugfixes:
     - Fix compile on OpenBSD 4.4-current. Bugfix on 0.2.1.5-alpha.
       Reported by Tas.
+    - When parsing ports in tor_addr_port_parse(), yield the port if
+      the port variable is provided, not just if it's nonzero.  Fixes
+      bug 809.  Bugfix on 0.2.1.5-alpha.
 
   o Minor features:
     - Use a lockfile to make sure that two Tor processes are not

Modified: tor/trunk/src/common/address.c
===================================================================
--- tor/trunk/src/common/address.c	2008-09-04 16:29:21 UTC (rev 16757)
+++ tor/trunk/src/common/address.c	2008-09-04 20:42:02 UTC (rev 16758)
@@ -917,7 +917,7 @@
     portval = 0;
   }
 
-  if (*port_out)
+  if (port_out)
     *port_out = portval;
   tor_addr_copy(addr_out, &addr);