[or-cvs] r17252: {tor} Be even _more_ careful when signatures are bogus. (tor/trunk/src/or)

[nickm at seul.org]

Author: nickm
Date: 2008-11-11 12:14:12 -0500 (Tue, 11 Nov 2008)
New Revision: 17252

Modified:
   tor/trunk/src/or/dirvote.c
Log:
Be even _more_ careful when signatures are bogus.

Modified: tor/trunk/src/or/dirvote.c
===================================================================
--- tor/trunk/src/or/dirvote.c	2008-11-11 16:52:19 UTC (rev 17251)
+++ tor/trunk/src/or/dirvote.c	2008-11-11 17:14:12 UTC (rev 17252)
@@ -2049,7 +2049,12 @@
       networkstatus_get_detached_signatures(pending_consensus);
     const char *src;
     char *dst, *dst_end;
-    size_t new_consensus_len =
+    size_t new_consensus_len;
+    if (!new_detached) {
+      *msg_out = "No signatures to add";
+      goto err;
+    }
+    new_consensus_len =
       strlen(pending_consensus_body) + strlen(new_detached) + 1;
     pending_consensus_body = tor_realloc(pending_consensus_body,
                                          new_consensus_len);