[or-cvs] r14041: Safebrowsing is out again. It is not authenticated in FF2 (F (in torbutton/trunk/src: . chrome/content)

[mikeperry at seul.org]

Author: mikeperry
Date: 2008-03-14 17:26:01 -0400 (Fri, 14 Mar 2008)
New Revision: 14041

Modified:
   torbutton/trunk/src/CHANGELOG
   torbutton/trunk/src/chrome/content/torbutton.js
Log:

Safebrowsing is out again. It is not authenticated in FF2
(Firefox Bug 360387).



Modified: torbutton/trunk/src/CHANGELOG
===================================================================
--- torbutton/trunk/src/CHANGELOG	2008-03-14 18:32:32 UTC (rev 14040)
+++ torbutton/trunk/src/CHANGELOG	2008-03-14 21:26:01 UTC (rev 14041)
@@ -10,7 +10,6 @@
   * misc: Improve window resizing to only resize on document load,
     and to try to address drift by remembering window sizes
   * misc: Clear session history if clear history on tor toggle is set
-  * misc: Re-enable safebrowsing updates during Tor
   * new: Remove history hooks in favor of nsISHistoryListeners that
     prevent history navigation from alternate Tor states
 

Modified: torbutton/trunk/src/chrome/content/torbutton.js
===================================================================
--- torbutton/trunk/src/chrome/content/torbutton.js	2008-03-14 18:32:32 UTC (rev 14040)
+++ torbutton/trunk/src/chrome/content/torbutton.js	2008-03-14 21:26:01 UTC (rev 14041)
@@ -627,6 +627,10 @@
     // so no need to keep it around for someone to rifle through.
     m_tb_prefs.setBoolPref("browser.cache.disk.enable", !mode);
 
+    // Disable safebrowsing in Tor. It fetches some info in cleartext
+    // with no HMAC (Firefox Bug 360387)
+    m_tb_prefs.setBoolPref("browser.safebrowsing.enabled", !mode);
+
     // I think this pref is evil (and also hidden from user configuration, 
     // which makes it extra evil) and so therefore am disabling it 
     // by fiat for both tor and non-tor. Basically, I'm not willing