[or-cvs] r13590: make explicit that we don't care if a rename() call fails. p (tor/trunk/src/or)

arma at seul.org arma at seul.org
Tue Feb 19 22:25:20 UTC 2008


Author: arma
Date: 2008-02-19 17:25:20 -0500 (Tue, 19 Feb 2008)
New Revision: 13590

Modified:
   tor/trunk/src/or/config.c
Log:
make explicit that we don't care if a rename() call fails.
potential bug reported by veracode.


Modified: tor/trunk/src/or/config.c
===================================================================
--- tor/trunk/src/or/config.c	2008-02-19 22:08:44 UTC (rev 13589)
+++ tor/trunk/src/or/config.c	2008-02-19 22:25:20 UTC (rev 13590)
@@ -4753,7 +4753,7 @@
       log_warn(LD_BUG, "Unable to parse state in \"%s\". Moving it aside "
                "to \"%s\".  This could be a bug in Tor; please tell "
                "the developers.", fname, fname2);
-      rename(fname, fname2);
+      (int)rename(fname, fname2);
     }
     tor_free(fname2);
     tor_free(contents);



More information about the tor-commits mailing list