[or-cvs] r11668: Fix a stupid logic error in authority_cert_get_by_sk_digest: (in tor/trunk: . src/or)

nickm at seul.org nickm at seul.org
Thu Sep 27 16:41:43 UTC 2007


Author: nickm
Date: 2007-09-27 12:41:42 -0400 (Thu, 27 Sep 2007)
New Revision: 11668

Modified:
   tor/trunk/
   tor/trunk/ChangeLog
   tor/trunk/src/or/routerlist.c
Log:
 r15418 at catbus:  nickm | 2007-09-27 12:37:59 -0400
 Fix a stupid logic error in authority_cert_get_by_sk_digest: the presence of an authority lacking a v3 cert does not mean that subsequent authorities lack them too.



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r15418] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-09-27 16:34:02 UTC (rev 11667)
+++ tor/trunk/ChangeLog	2007-09-27 16:41:42 UTC (rev 11668)
@@ -8,6 +8,10 @@
       OR address is readable, set the port correctly.  (Previously we
       were reporting the dir port.)  Bugfix on 0.1.2.x.
 
+  o Minor bugfixes (v3 directory code):
+    - Fix logic to look up a cert by its signing key digest.  Bugfix on
+      0.2.0.7-alpha.
+
 Changes in version 0.2.0.7-alpha - 2007-09-21
   o New directory authorities:
     - Set up moria1 and tor26 as the first v3 directory authorities. See

Modified: tor/trunk/src/or/routerlist.c
===================================================================
--- tor/trunk/src/or/routerlist.c	2007-09-27 16:34:02 UTC (rev 11667)
+++ tor/trunk/src/or/routerlist.c	2007-09-27 16:41:42 UTC (rev 11668)
@@ -388,7 +388,7 @@
   SMARTLIST_FOREACH(trusted_dir_servers, trusted_dir_server_t *, ds,
   {
     if (!ds->v3_certs)
-      return NULL;
+      continue;
     SMARTLIST_FOREACH(ds->v3_certs, authority_cert_t *, cert,
     {
       if (!memcmp(cert->signing_key_digest, sk_digest, DIGEST_LEN))



More information about the tor-commits mailing list