[or-cvs] r12070: Bugfix on r7072, which turned out to basically be a no-op: R (in tor/trunk: . src/or)

[arma at seul.org]

Author: arma
Date: 2007-10-21 00:15:28 -0400 (Sun, 21 Oct 2007)
New Revision: 12070

Modified:
   tor/trunk/ChangeLog
   tor/trunk/src/or/control.c
Log:
Bugfix on r7072, which turned out to basically be a no-op:
Respond to INT and TERM SIGNAL commands before we execute the
signal, in case the signal shuts us down. We had a patch in
0.1.2.1-alpha that tried to do this by queueing the response on
the connection's buffer before shutting down, but that really
isn't the same thing. Bug located by Matt Edman.

This is a bug in 0.1.2.x too, but there's no way we should backport
this fix. Speaking of which, can somebody double-check it? :)


Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-10-21 00:08:35 UTC (rev 12069)
+++ tor/trunk/ChangeLog	2007-10-21 04:15:28 UTC (rev 12070)
@@ -68,7 +68,7 @@
       detached signatures for a divergent vote.
     - Fix a small memory leak when computing a consensus.
 
-  o Minor bugfixes (v3 directory protocol)
+  o Minor bugfixes (v3 directory protocol):
     - Delete unverified-consensus when the real consensus is set.
     - Consider retrying a consensus networkstatus fetch immediately after one
       fails: don't wait 60 seconds to notice.
@@ -76,8 +76,13 @@
       exists before trying to replace the current one.
 
   o Minor bugfixes (controller):
-    - Don't reset trusted dir server list when we set a configuration option.
-      (Patch from Robert Hogan.)
+    - Don't reset trusted dir server list when we set a configuration
+      option. Patch from Robert Hogan.
+    - Respond to INT and TERM SIGNAL commands before we execute the
+      signal, in case the signal shuts us down. We had a patch in
+      0.1.2.1-alpha that tried to do this by queueing the response on
+      the connection's buffer before shutting down, but that really
+      isn't the same thing. Bug located by Matt Edman.
 
   o Minor bugfixes (memory leaks):
     - Stop leaking memory on failing case of base32_decode.  Bugfix on

Modified: tor/trunk/src/or/control.c
===================================================================
--- tor/trunk/src/or/control.c	2007-10-21 00:08:35 UTC (rev 12069)
+++ tor/trunk/src/or/control.c	2007-10-21 04:15:28 UTC (rev 12070)
@@ -1119,8 +1119,10 @@
   if (sig<0)
     return 0;
 
-  /* Send DONE first, in case the signal makes us shut down. */
   send_control_done(conn);
+  /* Flush the "done" first if the signal might make us shut down. */
+  if (sig == SIGTERM || sig == SIGINT)
+    connection_handle_write(TO_CONN(conn), 1);
   control_signal_act(sig);
   return 0;
 }