[or-cvs] r11914: note a bug in directories_have_accepted_server_descriptor() (tor/trunk/src/or)

[arma at seul.org]

Author: arma
Date: 2007-10-13 18:01:24 -0400 (Sat, 13 Oct 2007)
New Revision: 11914

Modified:
   tor/trunk/src/or/directory.c
Log:
note a bug in directories_have_accepted_server_descriptor() pointed
out by weasel


Modified: tor/trunk/src/or/directory.c
===================================================================
--- tor/trunk/src/or/directory.c	2007-10-13 21:57:02 UTC (rev 11913)
+++ tor/trunk/src/or/directory.c	2007-10-13 22:01:24 UTC (rev 11914)
@@ -192,6 +192,10 @@
 {
   smartlist_t *servers = router_get_trusted_dir_servers();
   or_options_t *options = get_options();
+  /* XXX020 If any authority of the needed type is down, this
+   * function will never return true. Perhaps we need to be
+   * tolerant of down servers? Or even better, should we change
+   * this so one successful upload is enough? -RD */
   SMARTLIST_FOREACH(servers, trusted_dir_server_t *, d, {
     if ((d->type & options->_PublishServerDescriptor) &&
         !d->has_accepted_serverdesc) {