[or-cvs] r11903: Move "sort a list of routerinfo_t" into its own function in (in tor/trunk: . src/or)

[nickm at seul.org]

Author: nickm
Date: 2007-10-12 17:33:37 -0400 (Fri, 12 Oct 2007)
New Revision: 11903

Modified:
   tor/trunk/
   tor/trunk/src/or/dirserv.c
   tor/trunk/src/or/routerlist.c
Log:
 r15731 at catbus:  nickm | 2007-10-12 17:27:48 -0400
 Move "sort a list of routerinfo_t" into its own function in routerlist.c



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r15731] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/trunk/src/or/dirserv.c
===================================================================
--- tor/trunk/src/or/dirserv.c	2007-10-12 21:33:35 UTC (rev 11902)
+++ tor/trunk/src/or/dirserv.c	2007-10-12 21:33:37 UTC (rev 11903)
@@ -1695,17 +1695,6 @@
   return 0;
 }
 
-/** Helper for sorting: compare two routerinfos by their identity
- * digest. */
-static int
-_compare_routerinfo_by_id_digest(const void **a, const void **b)
-{
-  routerinfo_t *first = *(routerinfo_t **)a, *second = *(routerinfo_t **)b;
-  return memcmp(first->cache_info.identity_digest,
-                second->cache_info.identity_digest,
-                DIGEST_LEN);
-}
-
 /** Helper for sorting: compares two routerinfos first by address, and then by
  * descending order of "usefulness".  (An authority is more useful than a
  * non-authority; a running router is more useful than a non-running router;
@@ -1754,7 +1743,9 @@
 
   /* They're equal! Compare by identity digest, so there's a
    * deterministic order and we avoid flapping. */
-  return _compare_routerinfo_by_id_digest(a, b);
+  return memcmp(first->cache_info.identity_digest,
+                second->cache_info.identity_digest,
+                DIGEST_LEN);
 }
 
 /** Given a list of routerinfo_t in <b>routers</b>, return a new digestmap_t
@@ -1913,7 +1904,7 @@
 
   routers = smartlist_create();
   smartlist_add_all(routers, rl->routers);
-  smartlist_sort(routers, _compare_routerinfo_by_id_digest);
+  routers_sort_by_identity(routers);
   omit_as_sybil = get_possible_sybil_list(routers);
 
   routerstatuses = smartlist_create();
@@ -2337,7 +2328,7 @@
 
   routers = smartlist_create();
   smartlist_add_all(routers, rl->routers);
-  smartlist_sort(routers, _compare_routerinfo_by_id_digest);
+  routers_sort_by_identity(routers);
 
   omit_as_sybil = get_possible_sybil_list(routers);
 

Modified: tor/trunk/src/or/routerlist.c
===================================================================
--- tor/trunk/src/or/routerlist.c	2007-10-12 21:33:35 UTC (rev 11902)
+++ tor/trunk/src/or/routerlist.c	2007-10-12 21:33:37 UTC (rev 11903)
@@ -4403,3 +4403,21 @@
   return info;
 }
 
+/** Helper for sorting: compare two routerinfos by their identity
+ * digest. */
+static int
+_compare_routerinfo_by_id_digest(const void **a, const void **b)
+{
+  routerinfo_t *first = *(routerinfo_t **)a, *second = *(routerinfo_t **)b;
+  return memcmp(first->cache_info.identity_digest,
+                second->cache_info.identity_digest,
+                DIGEST_LEN);
+}
+
+/** Sort a list of routerinfo_t in ascending order of identity digest. */
+void
+routers_sort_by_identity(smartlist_t *routers)
+{
+  smartlist_sort(routers, _compare_routerinfo_by_id_digest);
+}
+