[or-cvs] r11858: bugfix on r11480: Stop calling tor_strlower() on uninitializ (in tor/trunk: . src/or)

[arma at seul.org]

Author: arma
Date: 2007-10-10 19:44:10 -0400 (Wed, 10 Oct 2007)
New Revision: 11858

Modified:
   tor/trunk/ChangeLog
   tor/trunk/src/or/routerparse.c
Log:
bugfix on r11480:
Stop calling tor_strlower() on uninitialized memory in some cases.


Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-10-10 23:43:02 UTC (rev 11857)
+++ tor/trunk/ChangeLog	2007-10-10 23:44:10 UTC (rev 11858)
@@ -83,11 +83,15 @@
       cache when canceling a pending resolve.  Don't log unless stuff
       is fishy.  Resolves bug 463.
 
-  o Minor bugfixes (Security):
+  o Minor bugfixes (anonymity):
     - Never report that we've used more bandwidth than we're willing to
       relay: it leaks how much non-relay traffic we're using. Resolves
       bug 516.
 
+  o Minor bugfixes (of some sort):
+    - Stop calling tor_strlower() on uninitialized memory in some cases.
+      Bugfix in 0.2.0.7-alpha.
+
   o Code simplifications and refactoring:
     - Make a bunch of functions static.  Remove some dead code.
     - Pull out about a third of the really big routerlist.c; put it in a

Modified: tor/trunk/src/or/routerparse.c
===================================================================
--- tor/trunk/src/or/routerparse.c	2007-10-10 23:43:02 UTC (rev 11857)
+++ tor/trunk/src/or/routerparse.c	2007-10-10 23:44:10 UTC (rev 11858)
@@ -2355,10 +2355,10 @@
       return NULL;
     }
     cp = line;
+    tor_strlower(line);
   } else { /* assume an already well-formed address policy line */
     cp = s;
   }
-  tor_strlower(line);
 
   eos = cp + strlen(cp);
   tok = get_next_token(&cp, eos, routerdesc_token_table);