[or-cvs] r12498: Wow. Never name a js variable 'eval'. (torbutton/trunk/src/chrome/content)

mikeperry at seul.org mikeperry at seul.org
Thu Nov 15 09:18:19 UTC 2007


Author: mikeperry
Date: 2007-11-15 04:18:19 -0500 (Thu, 15 Nov 2007)
New Revision: 12498

Modified:
   torbutton/trunk/src/chrome/content/jshooks.js
Log:

Wow. Never name a js variable 'eval'.



Modified: torbutton/trunk/src/chrome/content/jshooks.js
===================================================================
--- torbutton/trunk/src/chrome/content/jshooks.js	2007-11-15 06:11:35 UTC (rev 12497)
+++ torbutton/trunk/src/chrome/content/jshooks.js	2007-11-15 09:18:19 UTC (rev 12498)
@@ -160,9 +160,9 @@
 }
 
 if (typeof(window.__HookObjects) != "undefined") {
-    var eval = 23;
+    var res = 23;
     if(!window.__HookObjects()) {
-        eval = 13;
+        res = 13;
     }
 
     window.__HookObjects = undefined;
@@ -176,5 +176,5 @@
     // XXX: test that breaking this and forcing hooks to apply
     // twice doesn't hurt anything.
     window.__tb_hooks_ran = true;
-    eval; // Secret result code.
+    res; // Secret result code.
 }



More information about the tor-commits mailing list