[or-cvs] r12470: another likelier candidate for mike's leak (tor/trunk/src/or)

[arma at seul.org]

Author: arma
Date: 2007-11-10 23:19:11 -0500 (Sat, 10 Nov 2007)
New Revision: 12470

Modified:
   tor/trunk/src/or/dns.c
Log:
another likelier candidate for mike's leak


Modified: tor/trunk/src/or/dns.c
===================================================================
--- tor/trunk/src/or/dns.c	2007-11-11 03:56:34 UTC (rev 12469)
+++ tor/trunk/src/or/dns.c	2007-11-11 04:19:11 UTC (rev 12470)
@@ -312,8 +312,8 @@
   tor_free(resolv_conf_fname);
 }
 
-/** Remove every cached_resolve whose <b>expire</b> time is before <b>now</b>
- * from the cache. */
+/** Remove every cached_resolve whose <b>expire</b> time is before or
+ * equal to <b>now</b> from the cache. */
 static void
 purge_expired_resolves(time_t now)
 {
@@ -385,6 +385,7 @@
       /* This should be in state DONE. Make sure it's not in the cache. */
       cached_resolve_t *tmp = HT_FIND(cache_map, &cache_root, resolve);
       tor_assert(tmp != resolve);
+      /* XXX020 shouldn't we be freeing 'resolve' here? */
     }
   }