[or-cvs] r10211: Note that we do not permit you to exit to port 0, no matter (in tor/trunk: . doc doc/spec)

[nickm at seul.org]

Author: nickm
Date: 2007-05-18 17:19:58 -0400 (Fri, 18 May 2007)
New Revision: 10211

Modified:
   tor/trunk/
   tor/trunk/doc/TODO
   tor/trunk/doc/spec/dir-spec.txt
   tor/trunk/doc/spec/tor-spec.txt
Log:
 r12983 at Kushana:  nickm | 2007-05-18 16:46:15 -0400
 Note that we do not permit you to exit to port 0, no matter what.  Closes bug 409.



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r12983] on c95137ef-5f19-0410-b913-86e773d04f59

Modified: tor/trunk/doc/TODO
===================================================================
--- tor/trunk/doc/TODO	2007-05-18 21:19:53 UTC (rev 10210)
+++ tor/trunk/doc/TODO	2007-05-18 21:19:58 UTC (rev 10211)
@@ -93,7 +93,7 @@
         o Implement, but make it option-controlled.
         o Make it always-on once it seems to work.
       o Implement option to download and cache extra-info documents.
-      - Improve the 'retry' logic on extra-info documents.
+      o Improve the 'retry' logic on extra-info documents.
       - Drop bandwidth history from router-descriptors
     - 105: Version negotiation for the Tor protocol (finalize by Jun 1)
     - 108: Base "Stable" Flag on Mean Time Between Failures

Modified: tor/trunk/doc/spec/dir-spec.txt
===================================================================
--- tor/trunk/doc/spec/dir-spec.txt	2007-05-18 21:19:53 UTC (rev 10210)
+++ tor/trunk/doc/spec/dir-spec.txt	2007-05-18 21:19:58 UTC (rev 10211)
@@ -417,7 +417,7 @@
 
        [Any number]
 
-       These lines describe the rules that an OR follows when
+       These lines describe an "exit policy": the rules that an OR follows when
        deciding whether to allow a new stream to a given address.  The
        'exitpattern' syntax is described below.  The rules are considered in
        order; if no rule matches, the address will be accepted.  For clarity,
@@ -570,7 +570,8 @@
    port ::= an integer between 1 and 65535, inclusive.
 
       [Some implementations incorrectly generate ports with value 0.
-       Implementations SHOULD accept this, and SHOULD NOT generate it.]
+       Implementations SHOULD accept this, and SHOULD NOT generate it.
+       Connections to port 0 are never permitted.]
 
    addrspec ::= "*" | ip4spec | ip6spec
    ipv4spec ::= ip4 | ip4 "/" num_ip4_bits | ip4 "/" ip4mask

Modified: tor/trunk/doc/spec/tor-spec.txt
===================================================================
--- tor/trunk/doc/spec/tor-spec.txt	2007-05-18 21:19:53 UTC (rev 10210)
+++ tor/trunk/doc/spec/tor-spec.txt	2007-05-18 21:19:58 UTC (rev 10211)
@@ -611,7 +611,7 @@
 
    where  ADDRESS can be a DNS hostname, or an IPv4 address in
    dotted-quad format, or an IPv6 address surrounded by square brackets;
-   and where PORT is encoded in decimal.
+   and where PORT is a decimal integer between 1 and 65535, inclusive.
 
    [What is the [00] for? -NM]
    [It's so the payload is easy to parse out with string funcs -RD]