[or-cvs] r10994: Disable SENTINELS in buffers: it may be responsible for maki (in tor/trunk: . src/or)

[nickm at seul.org]

Author: nickm
Date: 2007-07-30 13:51:14 -0400 (Mon, 30 Jul 2007)
New Revision: 10994

Modified:
   tor/trunk/ChangeLog
   tor/trunk/src/or/buffers.c
Log:
Disable SENTINELS in buffers: it may be responsible for making platform mallocs() be inefficient, and we havent needed it in a long long time.

Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-07-30 17:47:43 UTC (rev 10993)
+++ tor/trunk/ChangeLog	2007-07-30 17:51:14 UTC (rev 10994)
@@ -3,6 +3,11 @@
     - Be even more aggressive about releasing RAM from small
       empty buffers. Thanks to our free-list code, this shouldn't be too
       performance-intensive.
+    - Disable sentiel-based debugging for buffer code: we squashed all
+      the bugs that this was supposed to detect a long time ago, and
+      now its only effect is to change our buffer sizes from nice
+      powers of two (which platform mallocs tend to like) to values
+      siightly over powers of two (which make some platform mallocs sad).
 
 
 Changes in version 0.2.0.3-alpha - 2007-07-29

Modified: tor/trunk/src/or/buffers.c
===================================================================
--- tor/trunk/src/or/buffers.c	2007-07-30 17:47:43 UTC (rev 10993)
+++ tor/trunk/src/or/buffers.c	2007-07-30 17:51:14 UTC (rev 10994)
@@ -15,7 +15,7 @@
 
 #include "or.h"
 
-#define SENTINELS
+#undef SENTINELS
 #undef CHECK_AFTER_RESIZE
 #undef PARANOIA
 #undef NOINLINE