[or-cvs] r10816: Backport r10521: Fix a memory leak (in tor/branches/tor-0_1_2-patches: . doc src/or)

[nickm at seul.org]

Author: nickm
Date: 2007-07-12 13:00:42 -0400 (Thu, 12 Jul 2007)
New Revision: 10816

Modified:
   tor/branches/tor-0_1_2-patches/
   tor/branches/tor-0_1_2-patches/ChangeLog
   tor/branches/tor-0_1_2-patches/doc/TODO.012
   tor/branches/tor-0_1_2-patches/src/or/circuitbuild.c
Log:
 r13737 at catbus:  nickm | 2007-07-12 12:57:30 -0400
 Backport r10521: Fix a memory leak



Property changes on: tor/branches/tor-0_1_2-patches
___________________________________________________________________
 svk:merge ticket from /tor/012 [r13737] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/branches/tor-0_1_2-patches/ChangeLog
===================================================================
--- tor/branches/tor-0_1_2-patches/ChangeLog	2007-07-12 17:00:40 UTC (rev 10815)
+++ tor/branches/tor-0_1_2-patches/ChangeLog	2007-07-12 17:00:42 UTC (rev 10816)
@@ -37,6 +37,7 @@
     - Fix a possible (but very unlikely) bug in picking routers by bandwidth.
       Add a log message to confirm that it is in fact unlikely. (Patch from
       lodger.)
+    - Backport a couple of memory leak fixes.
     - Backport miscellaneous cosmetic bugfixes.
 
 

Modified: tor/branches/tor-0_1_2-patches/doc/TODO.012
===================================================================
--- tor/branches/tor-0_1_2-patches/doc/TODO.012	2007-07-12 17:00:40 UTC (rev 10815)
+++ tor/branches/tor-0_1_2-patches/doc/TODO.012	2007-07-12 17:00:42 UTC (rev 10816)
@@ -8,11 +8,10 @@
 	    a nonexistent hidden service port
   o r10493: weight guard selection by bandwidth
   o r10495: change an assert into a tor_assert
-  - r10521: fix an impossible^Wapparently real memory leak
+  o r10521: fix an impossible^Wapparently real memory leak
   o r10524: make the LICENSE and AUTHORS files mention Tor.
   o r10563: use correct types with desc_digest_map.
   o r10566: build correctly on systems where size_t is bigger than ulong. 
-  - r10579: new addsysuser implementation for osx (??)
   o r10643: eventdns.c behavior fix for solaris.
   - r10730: Don't choose guards after any never-connected-to guard. (??)
   o r10760: fix possible buffer overrun in old BSD natd code
@@ -20,4 +19,8 @@
   - Some fix for bug 455.
 
 
+Backport for 0.1.2.x once better tested:
+  - r10579: new addsysuser implementation for osx (??)
 
+
+

Modified: tor/branches/tor-0_1_2-patches/src/or/circuitbuild.c
===================================================================
--- tor/branches/tor-0_1_2-patches/src/or/circuitbuild.c	2007-07-12 17:00:40 UTC (rev 10815)
+++ tor/branches/tor-0_1_2-patches/src/or/circuitbuild.c	2007-07-12 17:00:42 UTC (rev 10816)
@@ -2255,10 +2255,8 @@
 entry_guards_prepend_from_config(void)
 {
   or_options_t *options = get_options();
-  smartlist_t *entry_routers = smartlist_create();
-  smartlist_t *old_entry_guards_on_list = smartlist_create();
-  smartlist_t *old_entry_guards_not_on_list = smartlist_create();
-  smartlist_t *entry_fps = smartlist_create();
+  smartlist_t *entry_routers, *entry_fps;
+  smartlist_t *old_entry_guards_on_list, *old_entry_guards_not_on_list;
   tor_assert(entry_guards);
 
   should_add_entry_nodes = 0;
@@ -2274,6 +2272,11 @@
   log_info(LD_CIRC,"Adding configured EntryNodes '%s'.",
            options->EntryNodes);
 
+  entry_routers = smartlist_create();
+  entry_fps = smartlist_create();
+  old_entry_guards_on_list = smartlist_create();
+  old_entry_guards_not_on_list = smartlist_create();
+
   /* Split entry guards into those on the list and those not. */
   add_nickname_list_to_smartlist(entry_routers, options->EntryNodes, 0);
   SMARTLIST_FOREACH(entry_routers, routerinfo_t *, ri,