[or-cvs] r9438: remove an XXX; add two more. (tor/trunk/src/or)

arma at seul.org arma at seul.org
Sat Jan 27 19:02:39 UTC 2007


Author: arma
Date: 2007-01-27 14:02:37 -0500 (Sat, 27 Jan 2007)
New Revision: 9438

Modified:
   tor/trunk/src/or/directory.c
Log:
remove an XXX; add two more.


Modified: tor/trunk/src/or/directory.c
===================================================================
--- tor/trunk/src/or/directory.c	2007-01-27 18:56:13 UTC (rev 9437)
+++ tor/trunk/src/or/directory.c	2007-01-27 19:02:37 UTC (rev 9438)
@@ -324,6 +324,8 @@
                                  0 /* don't retry_if_no_servers */);
 
     if (directory_conn_is_self_reachability_test(conn)) {
+      /* XXX012 look at the 'if' at the top of this function. this
+       * code will never be reached. -RD */
       routerinfo_t *me = router_get_my_routerinfo();
       if (me)
         control_event_server_status(LOG_WARN,
@@ -385,7 +387,7 @@
 connection_dir_download_routerdesc_failed(dir_connection_t *conn)
 {
   /* Try again. No need to increment the failure count for routerdescs, since
-   * it's not their fault.*/
+   * it's not their fault. */
   /* update_router_descriptor_downloads(time(NULL)); */
   (void) conn;
   /* XXXX012 Why did the above get commented out? -NM */
@@ -1828,7 +1830,7 @@
   if (!strcmp(url,"/tor/dir-all-weaselhack") &&
       (conn->_base.addr == 0x7f000001ul) &&
       authdir_mode(options)) {
-    /* XXX until weasel rewrites his scripts  XXXX012 */
+    /* until weasel rewrites his scripts at noreply */
     char *new_directory=NULL;
 
     if (dirserv_dump_directory_to_string(&new_directory,
@@ -2094,6 +2096,7 @@
                 cp, (int)rs->n_download_failures);
   });
 
+  /* XXX012 why did this get commented out too? */
   /* update_router_descriptor_downloads(time(NULL)); */
 }
 



More information about the tor-commits mailing list