[or-cvs] r9388: Fix an XXXX012 in routerlist.c: when we do not have enough n (in tor/trunk: . src/or)

[nickm at seul.org]

Author: nickm
Date: 2007-01-22 15:57:26 -0500 (Mon, 22 Jan 2007)
New Revision: 9388

Modified:
   tor/trunk/
   tor/trunk/ChangeLog
   tor/trunk/src/or/routerlist.c
Log:
 r9723 at catbus:  nickm | 2007-01-22 15:47:17 -0500
 Fix an XXXX012 in routerlist.c: when we do not have enough networkstatuses to launch router requests, do not launch router requests. Backport candidate.



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r9723] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-01-22 19:20:33 UTC (rev 9387)
+++ tor/trunk/ChangeLog	2007-01-22 20:57:26 UTC (rev 9388)
@@ -39,6 +39,10 @@
       correct order.
     - Free memory held in recently-completed DNS lookup attempts on exit.
       This was not a memory leak, but may have been hiding memory leaks.
+    - Don't launch requests for descriptors unless we have networkstatuses
+      from at least half of the authorities.  This delays the first download
+      slightly under pathological circumstances, but can prevent us from
+      downloading a bunch of descriptors we don't need.
 
   o Minor features:
     - Check for addresses with invalid characters at the exit as well as at

Modified: tor/trunk/src/or/routerlist.c
===================================================================
--- tor/trunk/src/or/routerlist.c	2007-01-22 19:20:33 UTC (rev 9387)
+++ tor/trunk/src/or/routerlist.c	2007-01-22 20:57:26 UTC (rev 9388)
@@ -3765,7 +3765,7 @@
       smartlist_len(networkstatus_list) <= get_n_v2_authorities()/2) {
     log_info(LD_DIR,
              "Not enough networkstatus documents to launch requests.");
-    /* XXX012 should we return here or something? */
+    return;
   }
 
   downloadable = router_list_client_downloadable();