[or-cvs] r9474: Note a few questionable bits pointed out by RATS. (And no, R (in tor/trunk: . src/common src/or)

[nickm at seul.org]

Author: nickm
Date: 2007-02-01 13:33:02 -0500 (Thu, 01 Feb 2007)
New Revision: 9474

Modified:
   tor/trunk/
   tor/trunk/src/common/log.c
   tor/trunk/src/or/eventdns.c
   tor/trunk/src/or/main.c
Log:
 r11624 at catbus:  nickm | 2007-02-01 13:17:35 -0500
 Note a few questionable bits pointed out by RATS.  (And no, RATS, I'm not about to stop having fixed-sized local buffers for you.  I know how to use them, thankyouverymuch.)



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r11624] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/trunk/src/common/log.c
===================================================================
--- tor/trunk/src/common/log.c	2007-02-01 18:09:34 UTC (rev 9473)
+++ tor/trunk/src/common/log.c	2007-02-01 18:33:02 UTC (rev 9474)
@@ -231,6 +231,8 @@
     }
     if (lf->is_syslog) {
 #ifdef HAVE_SYSLOG_H
+      /* XXXX Some syslog implementations have scary limits on the length of
+       * what you can pass them.  Can/should we detect this? */
       syslog(severity, "%s", end_of_prefix);
 #endif
       lf = lf->next;

Modified: tor/trunk/src/or/eventdns.c
===================================================================
--- tor/trunk/src/or/eventdns.c	2007-02-01 18:09:34 UTC (rev 9473)
+++ tor/trunk/src/or/eventdns.c	2007-02-01 18:33:02 UTC (rev 9474)
@@ -2768,6 +2768,7 @@
 	IP_ADDR_STRING *ns;
 	GetNetworkParams_fn_t fn;
 
+	/* XXXX Possibly, we should hardcode the location of this DLL. */
 	if (!(handle = LoadLibrary("iphlpapi.dll"))) {
 		log(EVDNS_LOG_WARN, "Could not open iphlpapi.dll");
 		//right now status = 0, doesn't that mean "good" - mikec

Modified: tor/trunk/src/or/main.c
===================================================================
--- tor/trunk/src/or/main.c	2007-02-01 18:09:34 UTC (rev 9473)
+++ tor/trunk/src/or/main.c	2007-02-01 18:33:02 UTC (rev 9474)
@@ -1775,6 +1775,7 @@
   if (service_fns.loaded)
     return 0;
 
+  /* XXXX Possibly, we should hardcode the location of this DLL. */
   if (!(library = LoadLibrary("advapi32.dll"))) {
     log_err(LD_GENERAL, "Couldn't open advapi32.dll.  Are you trying to use "
             "NT services on Windows 98? That doesn't work.");