[or-cvs] r9651: Fix connection_get_by_type_state_rendquery(): This has been (in tor/trunk: . src/or)

nickm at seul.org nickm at seul.org
Sun Feb 25 16:23:31 UTC 2007


Author: nickm
Date: 2007-02-25 11:22:36 -0500 (Sun, 25 Feb 2007)
New Revision: 9651

Modified:
   tor/trunk/
   tor/trunk/ChangeLog
   tor/trunk/src/or/connection.c
Log:
 r11942 at catbus:  nickm | 2007-02-25 11:22:12 -0500
 Fix connection_get_by_type_state_rendquery(): This has been bogus for most of 0.1.2.x.  Thanks to Karsten Loesing for finding the bug; fixes bug 399.



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/trunk [r11942] on 8246c3cf-6607-4228-993b-4d95d33730f1

Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-02-25 13:39:33 UTC (rev 9650)
+++ tor/trunk/ChangeLog	2007-02-25 16:22:36 UTC (rev 9651)
@@ -59,6 +59,8 @@
       DNS request.
     - Build with recent libevents on platforms that do not define the
       nonstandard types "u_int8_t" and friends.
+    - Correctly detect whether hidden service descriptor downloads are
+      in-progress. (Fixes bug 399.)
 
   o Minor features (controller):
     - Warn the user when an application uses the obsolete binary v0

Modified: tor/trunk/src/or/connection.c
===================================================================
--- tor/trunk/src/or/connection.c	2007-02-25 13:39:33 UTC (rev 9650)
+++ tor/trunk/src/or/connection.c	2007-02-25 16:22:36 UTC (rev 9651)
@@ -2062,10 +2062,10 @@
         !conn->marked_for_close &&
         (!state || state == conn->state)) {
       if (type == CONN_TYPE_DIR &&
-          rend_cmp_service_ids(rendquery, TO_DIR_CONN(conn)->rend_query))
+          !rend_cmp_service_ids(rendquery, TO_DIR_CONN(conn)->rend_query))
         return conn;
       else if (CONN_IS_EDGE(conn) &&
-               rend_cmp_service_ids(rendquery, TO_EDGE_CONN(conn)->rend_query))
+              !rend_cmp_service_ids(rendquery, TO_EDGE_CONN(conn)->rend_query))
         return conn;
     }
   }



More information about the tor-commits mailing list