[or-cvs] r8454: I tracked a bug in server-side reverse DNS to something conc (in tor/trunk: . doc src/or)

[nickm at seul.org]

Author: nickm
Date: 2006-09-21 20:45:08 -0400 (Thu, 21 Sep 2006)
New Revision: 8454

Modified:
   tor/trunk/
   tor/trunk/doc/TODO
   tor/trunk/src/or/dns.c
Log:
 r8901 at Kushana:  nickm | 2006-09-21 20:43:48 -0400
 I tracked a bug in server-side reverse DNS to something concerning the caching code. Ive disabled server-side cacheing for reverse DNS answers for now, and I am noting the bug in the TODO.



Property changes on: tor/trunk
___________________________________________________________________
 svk:merge ticket from /tor/branches/eventdns [r8901] on c95137ef-5f19-0410-b913-86e773d04f59

Modified: tor/trunk/doc/TODO
===================================================================
--- tor/trunk/doc/TODO	2006-09-22 00:44:21 UTC (rev 8453)
+++ tor/trunk/doc/TODO	2006-09-22 00:45:08 UTC (rev 8454)
@@ -109,6 +109,7 @@
       o Connect to resolve cells, server-side.
       o Add element to routerinfo to note routers that aren't using eventdns,
         so we can avoid sending them reverse DNS etc.
+      - Fix the bug with server-side caching, whatever is causing it.
       . Add client-side interface
         o SOCKS interface: specify
         o SOCKS interface: implement

Modified: tor/trunk/src/or/dns.c
===================================================================
--- tor/trunk/src/or/dns.c	2006-09-22 00:44:21 UTC (rev 8453)
+++ tor/trunk/src/or/dns.c	2006-09-22 00:45:08 UTC (rev 8454)
@@ -814,6 +814,11 @@
   if (outcome == DNS_RESOLVE_FAILED_TRANSIENT)
     return;
 
+  /* XXX This is dumb, but it seems to workaround a bug I can't find.  We
+   * should nail this so we can cache reverse DNS answers. -NM */
+  if (is_reverse)
+    return;
+
   //log_notice(LD_EXIT, "Adding to cache: %s -> %s (%lx, %s), %d",
   //           address, is_reverse?"(reverse)":"", (unsigned long)addr,
   //           hostname?hostname:"NULL",(int)outcome);