[or-cvs] Tor servers are also giving spurious "you"re invalid" warni...

arma at seul.org arma at seul.org
Tue May 9 09:47:49 UTC 2006


Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	routerlist.c 
Log Message:
Tor servers are also giving spurious "you're invalid" warnings.
This is because we get a lot of network statuses that don't list
us at all, and we conclude that they all think we're invalid.
The long-term fix is to get better logic, and the short-term fix
is to downgrade the log severity.


Index: routerlist.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/routerlist.c,v
retrieving revision 1.510
retrieving revision 1.511
diff -u -p -d -r1.510 -r1.511
--- routerlist.c	29 Apr 2006 18:42:26 -0000	1.510
+++ routerlist.c	9 May 2006 09:47:47 -0000	1.511
@@ -2777,12 +2777,12 @@ routers_update_all_from_networkstatus(vo
         ++n_named;
     });
 
-    if (n_recent && n_listing) {
-      if (n_valid <= n_recent/2)  {
-        log_warn(LD_GENERAL,
+    if (n_listing) {
+      if (n_valid <= n_listing/2)  {
+        log_info(LD_GENERAL,
                  "%d/%d recent statements from directory authorities list us "
                  "as unapproved. Are you misconfigured?",
-                 n_recent-n_valid, n_recent);
+                 n_listing-n_valid, n_listing);
         have_warned_about_invalid_status = 1;
       } else if (n_naming && !n_named) {
         log_info(LD_GENERAL, "0/%d name-binding directory authorities "



More information about the tor-commits mailing list