[or-cvs] if we"re a server and some peer has a broken tls certificat...

arma at seul.org arma at seul.org
Fri May 26 16:32:18 UTC 2006


Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	connection_or.c 
Log Message:
if we're a server and some peer has a broken tls certificate, don't
shout about it unless we want to hear about protocol violations.


Index: connection_or.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/connection_or.c,v
retrieving revision 1.216
retrieving revision 1.217
diff -u -p -d -r1.216 -r1.217
--- connection_or.c	18 Mar 2006 01:24:04 -0000	1.216
+++ connection_or.c	26 May 2006 16:32:16 -0000	1.217
@@ -581,11 +581,13 @@ connection_or_check_valid_handshake(conn
 
   check_no_tls_errors();
   if (! tor_tls_peer_has_cert(conn->tls)) {
-    log_info(LD_PROTOCOL,"Peer didn't send a cert! Closing.");
+    log_info(LD_PROTOCOL,"Peer (%s:%d) didn't send a cert! Closing.",
+             conn->address, conn->port);
     return -1;
   }
   check_no_tls_errors();
-  if (tor_tls_get_peer_cert_nickname(conn->tls, nickname, sizeof(nickname))) {
+  if (tor_tls_get_peer_cert_nickname(severity, conn->tls, nickname,
+                                     sizeof(nickname))) {
     log_fn(severity,LD_PROTOCOL,"Other side (%s:%d) has a cert without a "
            "valid nickname. Closing.",
            conn->address, conn->port);



More information about the tor-commits mailing list